lkml.org 
[lkml]   [2017]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 12/93] staging: gdm724x: gdm_mux: fix use-after-free on module unload
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit b58f45c8fc301fe83ee28cad3e64686c19e78f1c upstream.

    Make sure to deregister the USB driver before releasing the tty driver
    to avoid use-after-free in the USB disconnect callback where the tty
    devices are deregistered.

    Fixes: 61e121047645 ("staging: gdm7240: adding LTE USB driver")
    Cc: Won Kang <wkang77@gmail.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/gdm724x/gdm_mux.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/staging/gdm724x/gdm_mux.c
    +++ b/drivers/staging/gdm724x/gdm_mux.c
    @@ -664,9 +664,8 @@ static int __init gdm_usb_mux_init(void)

    static void __exit gdm_usb_mux_exit(void)
    {
    - unregister_lte_tty_driver();
    -
    usb_deregister(&gdm_mux_driver);
    + unregister_lte_tty_driver();
    }

    module_init(gdm_usb_mux_init);

    \
     
     \ /
      Last update: 2017-05-18 13:51    [W:4.115 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site