Messages in this thread | | | Date | Thu, 18 May 2017 13:25:01 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: tcrypt: don't disable irqs and wait |
| |
On Tue, Apr 25, 2017 at 11:25:40AM +0300, Gilad Ben-Yossef wrote: > The tcrypt AEAD cycles speed tests disables irqs during the test, which is > broken at the very least since commit > '1425d2d17f7309c6 ("crypto: tcrypt - Fix AEAD speed tests")' > adds a wait for completion as part of the test and probably since > switching to the new AEAD API. > > While the result of taking a cycle count diff may not mean much on SMP > systems if the task migrates, it's good enough for tcrypt being the quick > & dirty dev tool it is. It's also what all the other (i.e. hash) cycle > speed tests do. > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> > Reported-by: Ofir Drang <ofir.drang@arm.com>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |