lkml.org 
[lkml]   [2017]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/9] timers: remove old timer initialization macros
On Tue, May 16, 2017 at 09:43:34PM +0200, Arnd Bergmann wrote:
> > - * Don't use the macros below, use DECLARE_TIMER and INIT_TIMER with their
> > + * Don't use the macro below, use DECLARE_TIMER and INIT_TIMER with their
> > * improved callback signature above.
> > */
> > -#define __TIMER_INITIALIZER(_function, _expires, _data, _flags) { \
> > +#define DEFINE_TIMER(_name, _function, _expires, _data) \
> > + struct timer_list _name = { \
> > .entry = { .next = TIMER_ENTRY_STATIC }, \
> > .function = (_function), \
> > .expires = (_expires), \
> > .data = (_data), \
> > - .flags = (_flags), \
> > __TIMER_LOCKDEP_MAP_INITIALIZER( \
> > __FILE__ ":" __stringify(__LINE__)) \
> > }
>
> Not sure what to do about it, but I notice that the '_expires'
> argument is completely
> bogus, I don't see any way it could be used in a meaningful way, and the only
> user that passes anything other than zero is arch/mips/mti-malta/malta-display.c
> and that seems to be unintentional.

DEFINE_TIMER is the old macro and instead of fixing it up I'll just
make sure the new DECLARE_TIMER gets rid of it.

\
 
 \ /
  Last update: 2017-05-18 10:27    [W:0.049 / U:0.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site