Messages in this thread | | | From | Dan Williams <> | Date | Wed, 17 May 2017 12:12:00 -0700 | Subject | Re: [PATCH] dmaengine: remove redundant null check on req |
| |
On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Req is never null on at the point of the null check, so > remove this redundant check and just return &req->tx. > > Detected by CoverityScan, CID#1436147 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hi Colin,
Looks good, can you also include the driver name in your patch subjects?
For example "dmaengine, bcm-scm-raid: remove redundant null check on req", would make it clear that this is a driver fix and not a core dmaengine issue.
| |