Messages in this thread | | | Date | Wed, 17 May 2017 17:48:13 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 |
| |
On Wed, May 17, 2017 at 07:43:51AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-05-16 22:06, Krzysztof Kozlowski wrote: > > Exynos pinctrl drivers contain pretty big per-SoC data structures. The > > pinctrl-exynos object file contained code and data for both ARMv7 and > > ARMv8 SoCs thus it grew big. There will not be a shared image between > > ARMv7 and ARMv8 so there is no need to combine all of this into one > > driver. > > > > Splitting the data allows to make it more granular (e.g. code related to > > ARMv8 Exynos is self-contained), slightly speed up the compilation and > > reduce the effective size of compiled kernel. > > > > The common data structures and functions reside still in existing > > pinctrl-exynos.c. Only the SoC-specific parts were moved out to new > > files. Except marking few functions non-static and adding them to > > header, there were no functional changes in the code. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > > > Not tested on ARMv8 (Exynos5433, Exynos7). > > Works fine on TM2 (Exynos5433). > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Great, thanks! Much appreciated.
Best regards, Krzysztof
| |