lkml.org 
[lkml]   [2017]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control
On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synth_flush is called.

Minor nit, please line-wrap your changelog text at 72 columns so that I
don't have to do it "by hand".

>
> It also tries to ensure that hardware flow control is enabled, by setting CRTSCTS using tty's termios.
>
> Reported-by: John Covici <covici@ccs.covici.com>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> Index: linux-staging/drivers/staging/speakup/serialio.c
> ===================================================================

Are you using git? These lines are odd...

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-05-16 14:03    [W:0.116 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site