lkml.org 
[lkml]   [2017]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding
On 15/05/2017 at 19:34:17 -0700, Moritz Fischer wrote:
> On Fri, May 12, 2017 at 07:00:29PM -0500, Rob Herring wrote:
> > On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote:
> > > + <0> for RTC
> > > + <1> for RTC + Alarm (Interrupt)
> > > + <2> for RTC + Watchdog
> > > +
> > > +Required child:
> > > +A single available child device of type matching the "dallas,ds1374-mode"
> > > +property.
> > > +
> > > +Optional properties (watchdog):
> > > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin
> > > + on the device is used as interrupt for
> > > + the alarm
> >
> > Isn't presence of the interrupt property or not enough? It would be
> > kind of useless to have no interrupt and also not do anything on
> > timeout.
>
> So you're saying:
>
> If interrupt not present AND mode = <0> ignore interrupt
>
> If interrupt present AND mode = <1> (maybe define here would be nicer),
> make it an interrupt.
>

If mode == 1, WDSTR doesn't matter so it will always be on the INT pin
anyway.

> If interrupt not present AND mode = <2> then this implies that reset
> output is mapped to RST pin.
>
> If Interrupt present AND mode = <2> then this implies that the reset
> output is (re)mapped to INT pin?
>

Yes, I think this is sufficient.



--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2017-05-16 10:18    [W:1.889 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site