Messages in this thread | | | Subject | Re: [PATCH 3/3] coresight: etb10: Improve a size determination in etb_alloc_buffer() | From | SF Markus Elfring <> | Date | Mon, 15 May 2017 21:34:33 +0200 |
| |
>> +++ b/drivers/hwtracing/coresight/coresight-etb10.c >> @@ -278,8 +278,7 @@ static void *etb_alloc_buffer(struct coresight_device *csdev, int cpu, >> if (cpu == -1) >> cpu = smp_processor_id(); >> node = cpu_to_node(cpu); >> - >> - buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node); >> + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, node); > > I'm fine with this change but if it's going to happen, it has to be in > all the coresight drivers and not just this one - please respin with > all instances fixed. One patch per driver would be much appreciated.
Do you imagine that any more modules are affected in a similar way for this software area?
How do you think about other update suggestions from my selection which are waiting for a corresponding review?
Regards, Markus
| |