lkml.org 
[lkml]   [2017]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA
Hi Mark,

On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
>> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
>> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> >> If NO_DMA=y:
>
>> >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>
>> >> Add a dependency on HAS_DMA to fix this.
>
>> > There's no progress on fixing the architectures that don't do DMA to
>> > stub it out? :(
>
>> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?
>
> No, I was thinking more just not needing the dependency at all.

Then what's the point of the existence of COMPILE_TEST?
We can just have stubs for everything, and always build everything.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2017-05-15 12:22    [W:0.239 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site