lkml.org 
[lkml]   [2017]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 12/18] arm64: dts: meson-gxbb-vega-s95: Fix node order
    From
    Date
    On 05/13/2017 04:33 PM, Andreas Färber wrote:
    > Sort nodes referenced by label alphabetically.
    >
    > Signed-off-by: Andreas Färber <afaerber@suse.de>
    > ---
    > v1 -> v2:
    > * Rebased (new nodes added)
    >
    > .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 54 +++++++++++-----------
    > 1 file changed, 27 insertions(+), 27 deletions(-)
    >
    > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
    > index f4bfee8e2e08..346753fb6324 100644
    > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
    > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
    > @@ -111,18 +111,6 @@
    > };
    > };
    >
    > -&uart_AO {
    > - status = "okay";
    > - pinctrl-0 = <&uart_ao_a_pins>;
    > - pinctrl-names = "default";
    > -};
    > -
    > -&ir {
    > - status = "okay";
    > - pinctrl-0 = <&remote_input_ao_pins>;
    > - pinctrl-names = "default";
    > -};
    > -
    > &ethmac {
    > status = "okay";
    > pinctrl-0 = <&eth_rgmii_pins>;
    > @@ -149,21 +137,18 @@
    > };
    > };
    >
    > -&usb0_phy {
    > - status = "okay";
    > - phy-supply = <&usb_vbus>;
    > -};
    > -
    > -&usb1_phy {
    > - status = "okay";
    > -};
    > -
    > -&usb0 {
    > +&ir {
    > status = "okay";
    > + pinctrl-0 = <&remote_input_ao_pins>;
    > + pinctrl-names = "default";
    > };
    >
    > -&usb1 {
    > +&pwm_ef {
    > status = "okay";
    > + pinctrl-0 = <&pwm_e_pins>;
    > + pinctrl-names = "default";
    > + clocks = <&clkc CLKID_FCLK_DIV4>;
    > + clock-names = "clkin0";
    > };
    >
    > /* Wireless SDIO Module */
    > @@ -229,10 +214,25 @@
    > vmmcq-sumpply = <&vcc_1v8>;
    > };
    >
    > -&pwm_ef {
    > +&uart_AO {
    > status = "okay";
    > - pinctrl-0 = <&pwm_e_pins>;
    > + pinctrl-0 = <&uart_ao_a_pins>;
    > pinctrl-names = "default";
    > - clocks = <&clkc CLKID_FCLK_DIV4>;
    > - clock-names = "clkin0";
    > +};
    > +
    > +&usb0_phy {
    > + status = "okay";
    > + phy-supply = <&usb_vbus>;
    > +};
    > +
    > +&usb1_phy {
    > + status = "okay";
    > +};
    > +
    > +&usb0 {
    > + status = "okay";
    > +};
    > +
    > +&usb1 {
    > + status = "okay";
    > };
    >

    Hi Andreas,

    Like a previous attempt, I'm not OK with such rework since it will break bisect and add complexity for new patches handling.

    The order is not alphabetically ordered, live with it.

    Neil

    \
     
     \ /
      Last update: 2017-05-15 10:22    [W:4.181 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site