lkml.org 
[lkml]   [2017]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] ALSA: firewire-tascam: Use do { } while for loops executed at least once
Date
If a loop is intended to be executed at least once, it is better to use
"do { ... } while (...)" instead of "while (...) { ... }".
The former is easier to understand for the casual reviewer, and doesn't
require preinitializing the canary variable.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Compile-tested only.
---
sound/firewire/tascam/tascam-stream.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/firewire/tascam/tascam-stream.c b/sound/firewire/tascam/tascam-stream.c
index e433b92ac6904db5..4ea6845aae87fdef 100644
--- a/sound/firewire/tascam/tascam-stream.c
+++ b/sound/firewire/tascam/tascam-stream.c
@@ -80,17 +80,17 @@ static int set_clock(struct snd_tscm *tscm, unsigned int rate,

int snd_tscm_stream_get_rate(struct snd_tscm *tscm, unsigned int *rate)
{
- u32 data = 0x0;
unsigned int trials = 0;
+ u32 data;
int err;

- while (data == 0x0 && trials++ < 5) {
+ do {
err = get_clock(tscm, &data);
if (err < 0)
return err;

data = (data & 0xff000000) >> 24;
- }
+ } while (data == 0x0 && ++trials < 5);

/* Check base rate. */
if ((data & 0x0f) == 0x01)
--
2.7.4
\
 
 \ /
  Last update: 2017-05-15 10:20    [W:3.091 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site