lkml.org 
[lkml]   [2017]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] regmap: add regmap_debugfs_exit as devres action
Date
Instead of manually cleanup regmap_debugfs_exit, use devres action
to do the cleanup. This also works for external users of
regmap_attach_dev.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
The cast is not that pretty, but I found it better than making
regmap_debugfs_exit type unsafe...

This fixes warnings when reloading certain drivers making use of
regmap_debugfs_exit:
imx7d-pinctrl 30330000.iomuxc: Failed to create debugfs directory

--
Stefan

drivers/base/regmap/regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index b9a779a4a739..0e32e0e2f00a 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -528,6 +528,7 @@ int regmap_attach_dev(struct device *dev, struct regmap *map,
return -ENOMEM;
}
*m = map;
+ devm_add_action(dev, (void (*)(void *))regmap_debugfs_exit, map);
devres_add(dev, m);

return 0;
@@ -1215,7 +1216,6 @@ void regmap_exit(struct regmap *map)
struct regmap_async *async;

regcache_exit(map);
- regmap_debugfs_exit(map);
regmap_range_exit(map);
if (map->bus && map->bus->free_context)
map->bus->free_context(map->bus_context);
--
2.13.0
\
 
 \ /
  Last update: 2017-05-15 10:09    [W:0.065 / U:0.036 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site