Messages in this thread | | | Date | Fri, 12 May 2017 15:48:40 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver |
| |
On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote:
> On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: [..] > > So please let me know what you think about [1], if you don't like it > > I'll fix the things pointed to by Stephen and we'll have to live with > > the two calls. > > > My last reply was about [1]. Other platforms call > mbox_send_data()+mbox_client_txdone() see > drivers/firmware/tegra/bpmp.c, but you want to introduce another API > in the innards of the framework.
Okay, lets go with that then. I will incorporate the changes requested by Stephen and post a final version and then add the mbox_client_txdone() in the clients.
> If we must do it, it should be done > above the framework by introducing > > void mbox_send_message_and_tick(struct mbox_chan *chan, void *mssg) > OR > void mbox_ring_doorbell(struct mbox_chan *chan, void *mssg) > { > (void)mbox_send_message(chan, mssg); > mbox_client_txdone(chan, 0); > }
This sounds reasonable, but I would prefer that we get the two drivers merged - so I suggest that we deal with that later, when we see if its worth the effort.
Regards, Bjorn
| |