Messages in this thread | | | Subject | Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status | From | Pavel Belous <> | Date | Thu, 11 May 2017 23:02:17 +0300 |
| |
On 11.05.2017 21:29, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. It may seem that the err should be assigned to the > return code of the call to the various *offload_en_set calls and > then we check for failure, however, these functions are void and > never actually return any status. > > Since these error checks are redundant we can remove these > as well as err and the error exit label err_exit. > > Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically > dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pavel Belous <pavel.belous@aquantia.com>
Regards, Pavel
| |