Messages in this thread | | | Subject | Re: [PATCH] ethernet: aquantia: remove redundant checks on error status | From | Colin Ian King <> | Date | Thu, 11 May 2017 19:18:08 +0100 |
| |
On 11/05/17 19:16, David Miller wrote: > From: Colin King <colin.king@canonical.com> > Date: Thu, 11 May 2017 18:29:29 +0100 > >> From: Colin Ian King <colin.king@canonical.com> >> >> The error status err is initialized as zero and then being checked >> several times to see if it is less than zero even when it has not >> been updated. Since these checks are redundant we can remove these >> as well as err and the error exit label err_exit. >> >> Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically >> dead code") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Please enhance your commit message to also explain that the functions > being called around these checks all return void, to make it clear > that this isn't an issue of the return values not being checked. > > Thanks. > Good idea. Will do.
| |