lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 020/129] power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Liam Breck <liam@networkimprov.net>

    commit 767eee362fd72bb2ca44cc80419ca4b38c6d8369 upstream.

    The interrupt signal is TRIGGER_FALLING. This is is specified in the
    data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us
    pulse to host to report charger device status and fault."

    Also the direction can be seen in the data sheet Figure 37 "BQ24190
    with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k
    pull-up resistor installed for the sample configurations.

    Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
    Signed-off-by: Liam Breck <kernel@networkimprov.net>
    Acked-by: Mark Greer <mgreer@animalcreek.com>
    Acked-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sebastian Reichel <sre@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/power/supply/bq24190_charger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/power/supply/bq24190_charger.c
    +++ b/drivers/power/supply/bq24190_charger.c
    @@ -1394,7 +1394,7 @@ static int bq24190_probe(struct i2c_clie

    ret = devm_request_threaded_irq(dev, bdi->irq, NULL,
    bq24190_irq_handler_thread,
    - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
    + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
    "bq24190-charger", bdi);
    if (ret < 0) {
    dev_err(dev, "Can't set up irq handler\n");

    \
     
     \ /
      Last update: 2017-05-11 17:58    [W:4.131 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site