lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 127/129] drm: mxsfb: drm_dev_alloc() returns error pointers
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit e89e50ac35d9126907a436dabe70f9a8311b9981 upstream.

    We should be checking for IS_ERR() instead of NULL because
    drm_dev_alloc() returns error pointers.

    Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: http://patchwork.freedesktop.org/patch/msgid/20161213122332.GA7519@elgon.mountain
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
    +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
    @@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_d
    pdev->id_entry = of_id->data;

    drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
    - if (!drm)
    - return -ENOMEM;
    + if (IS_ERR(drm))
    + return PTR_ERR(drm);

    ret = mxsfb_load(drm, 0);
    if (ret)

    \
     
     \ /
      Last update: 2017-05-11 17:22    [W:4.133 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site