lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 117/129] rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Michal Schmidt <mschmidt@redhat.com>


    [ Upstream commit 77ef033b687c3e030017c94a29bf6ea3aaaef678 ]

    IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0.
    Otherwise libnl3 fails to validate netlink messages with this attribute.
    "ip -detail a" assumes too that the attribute is NUL-terminated when
    printing it. It often was, due to padding.

    I noticed this as libvirtd failing to start on a system with sfc driver
    after upgrading it to Linux 4.11, i.e. when sfc added support for
    phys_port_name.

    Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/rtnetlink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/core/rtnetlink.c
    +++ b/net/core/rtnetlink.c
    @@ -1059,7 +1059,7 @@ static int rtnl_phys_port_name_fill(stru
    return err;
    }

    - if (nla_put(skb, IFLA_PHYS_PORT_NAME, strlen(name), name))
    + if (nla_put_string(skb, IFLA_PHYS_PORT_NAME, name))
    return -EMSGSIZE;

    return 0;

    \
     
     \ /
      Last update: 2017-05-11 17:20    [W:4.019 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site