lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 053/103] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Krzysztof Kozlowski <krzk@kernel.org>

    commit 3f6026b1dcb3c8ee71198c485a72ac674c6890dd upstream.

    Returning from for_each_available_child_of_node() loop requires cleaning
    up node refcount. Error paths lacked it so for example in case of
    deferred probe, the refcount of phy node was left increased.

    Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/ehci-exynos.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/usb/host/ehci-exynos.c
    +++ b/drivers/usb/host/ehci-exynos.c
    @@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct de
    if (IS_ERR(phy)) {
    ret = PTR_ERR(phy);
    if (ret == -EPROBE_DEFER) {
    + of_node_put(child);
    return ret;
    } else if (ret != -ENOSYS && ret != -ENODEV) {
    dev_err(dev,
    "Error retrieving usb2 phy: %d\n", ret);
    + of_node_put(child);
    return ret;
    }
    }

    \
     
     \ /
      Last update: 2017-05-11 17:10    [W:4.158 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site