Messages in this thread | | | Subject | Re: [PATCH] FS: Fixing return type of unsigned_offsets | From | Joe Perches <> | Date | Wed, 10 May 2017 21:55:35 -0700 |
| |
On Thu, 2017-05-11 at 10:13 +0530, Pushkar Jambhlekar wrote: > Should I change my implementation, i.e. remove '!!'?
That'd be up to Al.
At least one implementation using similar bit comparisons in fs/*.c does not use !!
fs/locks.c:static bool lease_breaking(struct file_lock *fl) fs/locks.c-{ fs/locks.c- return fl->fl_flags & (FL_UNLOCK_PENDING | FL_DOWNGRADE_PENDING) fs/locks.c-}
I didn't look very hard.
| |