Messages in this thread | | | From | Luc Van Oostenryck <> | Date | Thu, 11 May 2017 01:41:15 +0200 | Subject | Re: [PATCH] tpm: fix byte order related arithmetic inconsistency in tpm_getcap() |
| |
On Wed, May 10, 2017 at 2:34 PM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> Arithmetic should work but it's not a good practice to do additions, > substractions or multiplications in any other byte order than the CPU > byte order. > > sparse also complains about this. > > /Jarkko
Arithmetic should work? let's try with 0x0080: in native order: 0x0080 + 0x0080 = 0x0100 in reverse order: 0x8000 + 0x8000 = 0x0000 != swap16(0x0100)
Or do I misunderstand what you mean by "arithmetic should work"?
-- Luc Van Oostenryck
| |