Messages in this thread | | | Date | Mon, 1 May 2017 12:44:30 +0200 | From | Johannes Weiner <> | Subject | Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out |
| |
On Fri, Apr 28, 2017 at 05:40:44PM +0900, Minchan Kim wrote: > However, get_swap_page is ugly now. The caller should take care of > failure and should retry after split. I hope get_swap_page includes > split and retry logic in itself without reling on the caller.
I think this makes the interface terrible. It's an allocation function to which you pass a reference object for size - and if the allocation doesn't succeed it'll split your reference object to make it fit?
That's a nasty side effect for this function to have.
| |