lkml.org 
[lkml]   [2017]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v2] input: touchscreen: ar1021_i2c: use BIT to check for a bit
On Sun, Apr 30, 2017 at 09:38:53PM +0200, Martin Kepplinger wrote:
> The MSB for the first byte of touch data transmission is always 1. Make
> it a little more obvious we're testing this bit by using BIT(7).
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>

Applied, thank you.

> ---
>
> I'd still use the definition :) but otherwise I'd write the following.
> It really doesn't matter though.
>
> thanks for the quick support Dmitry,
>
> martin
>
>
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index eb1874fe52c2..8c76aa435903 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id)
> goto out;
>
> /* sync bit set ? */
> - if ((data[0] & 0x80) == 0)
> + if (!(data[0] & BIT(7)))
> goto out;
>
> button = data[0] & BIT(0);
> --
> 2.11.0
>

--
Dmitry

\
 
 \ /
  Last update: 2017-05-01 21:40    [W:2.197 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site