Messages in this thread | | | Date | Mon, 1 May 2017 18:10:30 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver |
| |
> > > > Does the internal PHY have a phy driver? It seems like > > > > tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so > > > > should be in the phy driver, if it has one. > > > > > > Nope. These affect the delay lines for the external PHY interface. > > I will add some sentences in the documentation to be more clear about that.
Thanks
> > > > > Oh, yes. I understood the patch wrong. > > > > None of the patches actually use these properties. Are they actually > > needed? We should avoid adding vendor specific properties, if they are > > not used. > > > > The board that use it is the BananaPi M3, but the SoC A83T still lack clocks support. > So theses properties is already used out of tree, and will be used in tree soon.
Fair enough.
Thanks Andrew
| |