lkml.org 
[lkml]   [2017]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] sched/fair: Fix how load gets propagated from cfs_rq to its sched_entity
On Mon, May 01, 2017 at 04:17:33PM +0200, Peter Zijlstra wrote:

> So this here does:
>
> ( tg->load_avg = \Sum cfs_rq->load_avg )
>
> load = cfs_rq->load.weight
>
> tg_weight = tg->load_avg - cfs_rq->contrib + load
>
>
> tg->shares * load
> shares = -----------------
> tg_weight
>
>
> cfs_rq->load_avg
> avg_shares = shares * ----------------
> load
>
> tg->shares * cfs_rq->load_avg
> = -----------------------------
> tg_weight
>
>
> ( se->load.weight = shares )
>
> se->load_avg = min(shares, avg_shares);

I wonder though; do we really need the min() ? Can't we simply use
avg_shares all the time?


\
 
 \ /
  Last update: 2017-05-01 16:54    [W:0.310 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site