Messages in this thread | | | Date | Fri, 7 Apr 2017 10:00:13 +0200 | From | Michal Hocko <> | Subject | Re: [patch] mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff() |
| |
On Thu 06-04-17 13:16:24, David Rientjes wrote: > We got need_resched() warnings in swap_cgroup_swapoff() because > swap_cgroup_ctrl[type].length is particularly large. > > Reschedule when needed. > > Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > mm/swap_cgroup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/swap_cgroup.c b/mm/swap_cgroup.c > --- a/mm/swap_cgroup.c > +++ b/mm/swap_cgroup.c > @@ -201,6 +201,8 @@ void swap_cgroup_swapoff(int type) > struct page *page = map[i]; > if (page) > __free_page(page); > + if (!(i % SWAP_CLUSTER_MAX)) > + cond_resched(); > } > vfree(map); > } > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
-- Michal Hocko SUSE Labs
| |