lkml.org 
[lkml]   [2017]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/7] x86/hyperv: implement rep hypercalls
Date
> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Friday, April 7, 2017 04:27
> To: devel@linuxdriverproject.org; x86@kernel.org
> Cc: linux-kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>;
> Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; Thomas Gleixner <tglx@linutronix.de>; Ingo
> Molnar <mingo@redhat.com>; H. Peter Anvin <hpa@zytor.com>; Steven
> Rostedt <rostedt@goodmis.org>; Jork Loeser <Jork.Loeser@microsoft.com>
> Subject: [PATCH 4/7] x86/hyperv: implement rep hypercalls

> diff --git a/arch/x86/include/asm/mshyperv.h
> b/arch/x86/include/asm/mshyperv.h index 9a5f58b..a2c996b 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -4,6 +4,7 @@
> #include <linux/types.h>
> #include <linux/interrupt.h>
> #include <linux/clocksource.h>
> +#include <linux/nmi.h>
> #include <asm/hyperv.h>
>
> /*
> @@ -253,6 +254,26 @@ static inline u64 hv_do_fast_hypercall8(u16 code,
> u64 input1) #endif }
>
> +static inline u64 hv_do_rep_hypercall(u16 code, u16 rep_count, void
> *input,
> + void *output)
> +{
> + union hv_hypercall_input hc_input = { .code = code,
> + .rep_count = rep_count};

Is there a way to statically verify the re-count not to exceed 12 bits? Could a dynamic check be justified? Perhaps a function comment?

\
 
 \ /
  Last update: 2017-04-07 21:48    [W:0.179 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site