Messages in this thread | | | Date | Fri, 7 Apr 2017 12:06:01 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/5] perf stat: Refactor the code to strip csv output with ltrim() |
| |
Em Fri, Apr 07, 2017 at 11:24:18PM +0900, Taeung Song escreveu: > To strip csv output, use ltrim() instead of > just while loop and isspace() at print_metric_{only}_csv().
Applied.
> Cc: Andi Kleen <ak@linux.intel.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Namhyung Kim <namhyung@kernel.org> > Signed-off-by: Taeung Song <treeze.taeung@gmail.com> > --- > tools/perf/builtin-stat.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 2158ea1..868e086a 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -875,10 +875,7 @@ static void print_metric_csv(void *ctx, > return; > } > snprintf(buf, sizeof(buf), fmt, val); > - vals = buf; > - while (isspace(*vals)) > - vals++; > - ends = vals; > + ends = vals = ltrim(buf); > while (isdigit(*ends) || *ends == '.') > ends++; > *ends = 0; > @@ -950,10 +947,7 @@ static void print_metric_only_csv(void *ctx, const char *color __maybe_unused, > return; > unit = fixunit(tbuf, os->evsel, unit); > snprintf(buf, sizeof buf, fmt, val); > - vals = buf; > - while (isspace(*vals)) > - vals++; > - ends = vals; > + ends = vals = ltrim(buf); > while (isdigit(*ends) || *ends == '.') > ends++; > *ends = 0; > -- > 2.7.4
| |