Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 7 Apr 2017 11:44:31 +0200 | Subject | Re: [PATCH v4 06/14] MIPS: jz4740: DTS: Add nodes for ingenic pinctrl and gpio drivers |
| |
On Sun, Apr 2, 2017 at 10:42 PM, Paul Cercueil <paul@crapouillou.net> wrote:
> For a description of the pinctrl devicetree node, please read > Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.txt > > For a description of the gpio devicetree nodes, please read > Documentation/devicetree/bindings/gpio/ingenic,gpio.txt > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > arch/mips/boot/dts/ingenic/jz4740.dtsi | 61 ++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > v2: Changed the devicetree bindings to match the new driver > v3: No changes > v4: Update the bindings for the v4 version of the drivers (...)
> + pinctrl: ingenic-pinctrl@10010000 { > + compatible = "ingenic,jz4740-pinctrl"; > + reg = <0x10010000 0x400>; > + > + gpa: gpio-controller@0 { > + compatible = "ingenic,gpio-bank-a", "ingenic,jz4740-gpio";
As Sergei and Rob notes, the bank compatible properties look a bit strange. Especially if they are all the same essentially.
I like Sergei's idea to simply use the reg property if what you want is really a unique ID number. What do you think about this?
Yours, Linus Walleij
| |