lkml.org 
[lkml]   [2017]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH 1/2] drm/vgem: Add a dummy platform device
Date
The vgem driver is currently registered independent of any actual
device. Some usage of the dmabuf APIs require an actual device structure
to do anything. Register a dummy platform device for use with dmabuf.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
I realize the original driver had a note about 'drop platform support'. I
strongly dislike platform devices but they are the easiest way to get a device
structure for use with APIs like dmabuf.
---
drivers/gpu/drm/vgem/vgem_drv.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index a1f42d1..b94feef 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -329,12 +329,19 @@ static struct drm_driver vgem_driver = {
};

static struct drm_device *vgem_device;
+static struct platform_device *vgem_pdev;

static int __init vgem_init(void)
{
int ret;

- vgem_device = drm_dev_alloc(&vgem_driver, NULL);
+ vgem_pdev = platform_device_register_simple("vgem", -1, NULL, 0);
+ if (IS_ERR(vgem_pdev))
+ return PTR_ERR(vgem_pdev);
+
+ dma_coerce_mask_and_coherent(&vgem_pdev->dev, DMA_BIT_MASK(64));
+
+ vgem_device = drm_dev_alloc(&vgem_driver, &vgem_pdev->dev);
if (IS_ERR(vgem_device)) {
ret = PTR_ERR(vgem_device);
goto out;
@@ -349,6 +356,8 @@ static int __init vgem_init(void)
out_unref:
drm_dev_unref(vgem_device);
out:
+ platform_device_unregister(vgem_pdev);
+
return ret;
}

@@ -356,6 +365,7 @@ static void __exit vgem_exit(void)
{
drm_dev_unregister(vgem_device);
drm_dev_unref(vgem_device);
+ platform_device_unregister(vgem_pdev);
}

module_init(vgem_init);
--
2.7.4
\
 
 \ /
  Last update: 2017-04-07 01:20    [W:0.584 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site