Messages in this thread | | | Date | Thu, 6 Apr 2017 16:07:26 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation |
| |
El Fri, Apr 07, 2017 at 12:51:57AM +0200 Johannes Berg ha dit:
> On Thu, 2017-04-06 at 15:42 -0700, Matthias Kaehlcke wrote: > > > > Thanks, it would also require to move the initialization of > > ieee80211_default_rc_algo into an ifdef. If you can live with such a > > solution I'm happy to change it. > > I think that'd be something I can live with, yeah. > > > > git grep 'IS_ENABLED(' | grep '&&' > > > > Indeed the warning is not triggered by these constructs. It seems > > clang only emits the warning when the constant operand is not > > boolean. > > That points to just adding "> 0" to the condition here as another > alternative solution, I guess? With a comment to make sure it's not > removed again, that'd seem like the best thing to do.
Good point, that's more digestible. I'll send an updated change soon.
Matthias
| |