Messages in this thread | | | Date | Thu, 6 Apr 2017 20:34:21 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery |
| |
On Thu, 6 Apr 2017, Benjamin Tissoires wrote:
> > > Without a scope defined, UPower assumes that the battery provides > > > power to the computer it's connected to, like a laptop battery or a UPS. > > > > > > Tested-by: Peter Hutterer <peter.hutterer@who-t.net> > > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > > > --- > > > > > > no changes in v3 > > > > > > changes in v2: > > > * fixed typo in commit message > > > --- > > > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > > > index 4eeb550..4aaf237 100644 > > > --- a/drivers/hid/hid-logitech-hidpp.c > > > +++ b/drivers/hid/hid-logitech-hidpp.c > > > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > > > static enum power_supply_property hidpp_battery_props[] = { > > > POWER_SUPPLY_PROP_STATUS, > > > POWER_SUPPLY_PROP_CAPACITY, > > > + POWER_SUPPLY_PROP_SCOPE, > > > > This certainly assumes some other patchset to be already applied, right? > > Hehe, once again you forgot about it, and me to make a note about it > too ;-)
Bah, right; I was pretty sure we've discussed this, but was not able to find in anywhere in the history :)
Now queued in for-4.12/logitech-hidpp-battery-power-supply. Thanks,
-- Jiri Kosina SUSE Labs
| |