lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/2] Alps HID I2C T4 device support
    Date
    Hi, Nikolaus,

    Could you add below debug message to hid-alps.c, and check it?
    This device is "HID_DEVICE_ID_ALPS_T4_BTNLESS"(0x120C).
    If the device is UNKNOWN, this device does not work completely.
    And if the system does not call here, it has nothing to do with my patch.

    static int alps_probe()
    { ...
    ...
    ...
    printk("====> ALPS Debug Log: (%x) \n", hdev->product);
    switch (hdev->product) {
    case HID_DEVICE_ID_ALPS_T4_BTNLESS:
    data->dev_type = T4;
    break;
    case HID_DEVICE_ID_ALPS_U1_DUAL:
    data->dev_type = U1;
    break;
    default:
    data->dev_type = UNKNOWN;
    }

    Best Regards,
    Masaki Ota
    -----Original Message-----
    From: Nikolaus Rath [mailto:Nikolaus@rath.org]
    Sent: Thursday, April 06, 2017 3:36 AM
    To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
    Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-input@vger.kernel.org
    Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support

    Hi Masaki,

    Could you be a little more specific about what you need? I don't like executing scripts containing several instances of 'sudo rm -rf [something]'.

    It seems that the script is meant to install debugging versions of some modules. Could you simply send me a patch against the official kernel that includes your debugging code? I'm perfectly able to compile it and load the modules on my own :-).

    Thanks,
    -Nikolaus

    On Apr 05 2017, Masaki Ota <masaki.ota@jp.alps.com> wrote:
    > Hi, Nikolaus,
    >
    > If you have a time, please try below debug method.
    >
    > Download below file, copy it to your system and unpack.
    > https://www.filesanywhere.com/fs/v.aspx?v=8b716a8e5b6773baa799
    >
    > Procedure ex:
    > #cd Desktop/LinuxModDebug
    > #sudo chmod 755 linux_kr_rebuild_tool_hid.sh #sudo
    > ./linux_kr_rebuild_tool_hid.sh /init linux-4.10.tar.gz #sudo
    > ./linux_kr_rebuild_tool_hid.sh /build DebugSrc
    >
    > After that Touchpad all features should work.
    > If Touchpad does not work, something error appears on dmesg.
    >
    > Best Regards,
    > Masaki Ota
    > -----Original Message-----
    > From: Nikolaus Rath [mailto:Nikolaus@rath.org]
    > Sent: Wednesday, April 05, 2017 9:01 AM
    > To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
    > Cc: linux-kernel <linux-kernel@vger.kernel.org>;
    > linux-input@vger.kernel.org
    > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support
    >
    > Hi Masaki,
    >
    > Well, I'd be pleasently surprised if every bug always came together
    > with an associated error message :-). No matter if there's a dmesg
    > entry or not, at the moment this patch will make life much worse for
    > at least some EliteBook owners.
    >
    > Is there anything I can do to help you debug this?
    >
    > Best,
    > -Nikolaus
    >
    >
    > On Apr 04 2017, Masaki Ota <masaki.ota@jp.alps.com> wrote:
    >> Hi, Nikolaus,
    >>
    >> Um, but demesg log does not have any error of this Touchpad.
    >> It's a strange.
    >>
    >> Best Regards,
    >> Masaki Ota
    >> -----Original Message-----
    >> From: Nikolaus Rath [mailto:Nikolaus@rath.org]
    >> Sent: Wednesday, April 05, 2017 8:43 AM
    >> To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
    >> Cc: linux-kernel <linux-kernel@vger.kernel.org>;
    >> linux-input@vger.kernel.org
    >> Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support
    >>
    >> Hi Masaki,
    >>
    >> Yes, without your patch the touchpad is mostly working - I just can't configure it.
    >>
    >> Please take a look at https://bugs.freedesktop.org/show_bug.cgi?id=100345.
    >>
    >> Best,
    >> -Nikolaus
    >>
    >> On Apr 04 2017, Masaki Ota <masaki.ota@jp.alps.com> wrote:
    >>> Hi, Nikolaus,
    >>>
    >>> There is no 044E:120C device, but it looks like Alps Touchpad is detected as PS/2 Touchpad.
    >>>
    >>> Actually, this Touchpad has two interfaces. One is I2C, the other is PS/2.
    >>> Default setting is I2C, and if the system does not support I2C, Touchpad works as PS/2.
    >>>
    >>> However, both of interface should work properly on Linux.
    >>> I tested it on Ubuntu +4.10 kernel.
    >>>
    >>> If you don't apply my patch, does device work as I2C? (044E:120C
    >>> appears?)
    >>>
    >>> Best Regards,
    >>> Masaki Ota
    >>> -----Original Message-----
    >>> From: Nikolaus Rath [mailto:Nikolaus@rath.org]
    >>> Sent: Wednesday, April 05, 2017 2:09 AM
    >>> To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
    >>> Cc: linux-kernel <linux-kernel@vger.kernel.org>;
    >>> linux-input@vger.kernel.org
    >>> Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support
    >>>
    >>> Hi Masaki,
    >>>
    >>> Yes, I think I have a 044E:120C. Is there a way to find out for sure?
    >>> It's not listed by e.g. lspci.
    >>>
    >>> The touchpad is definitely not reacting to anything. evemu-record does not show any events either.
    >>>
    >>> I have attached the dmesg output.
    >>>
    >>> Best,
    >>> -Nikolaus
    >>>
    >>>
    >>> On Apr 04 2017, Masaki Ota <masaki.ota@jp.alps.com> wrote:
    >>>> Hi, Nikolaus,
    >>>>
    >>>> Your Touchpad is 044E:120C, right?
    >>>>
    >>>> PATCH 1/2 supports 044E:120C Touchpad device.
    >>>> I think you can use all features of this Touchpad.
    >>>>
    >>>> PATCH 2/2 supports 044E:1215 Touchpad device.
    >>>> You don't need to care about this.
    >>>>
    >>>> If Touchpad does not work completely, there is something an error.
    >>>> What does dmesg show?
    >>>>
    >>>> Best Regards,
    >>>> Masaki Ota
    >>>> -----Original Message-----
    >>>> From: Nikolaus Rath [mailto:Nikolaus@rath.org]
    >>>> Sent: Tuesday, April 04, 2017 12:09 PM
    >>>> To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>; linux-kernel
    >>>> <linux-kernel@vger.kernel.org>; linux-input@vger.kernel.org
    >>>> Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support
    >>>>
    >>>> Hi Ota,
    >>>>
    >>>>> -Support Alps HID I2C T4 Touchpad device.
    >>>>> -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook
    >>>>> Folio G1, Elitebook 1030 G1, Elitebook 1040 G3
    >>>>>
    >>>>> Signed-off-by: Masaki Ota <masaki.ota@xxxxxxxxxxx>
    >>>>> ---
    >>>>> drivers/hid/hid-alps.c | 500 +++++++++++++++++++++++++++++++++++++++----------
    >>>>> drivers/hid/hid-core.c | 3 +-
    >>>>> drivers/hid/hid-ids.h | 1 +
    >>>>> 3 files changed, 403 insertions(+), 101 deletions(-)
    >>>>
    >>>> I tried your patch on an HP Elitebook, but with rather limited
    >>>> success. Before, I was able to use the touchpad in limited fashion
    >>>> (https://bugs.freedesktop.org/show_bug.cgi?id=100345). With your
    >>>> patch (applied on top of 4.10), the touchpad no longer reacts at all.
    >>>>
    >>>> That said, I didn't find a patch 2/2 anywhere.. is there something missing?
    >>>>
    >>>> Thanks,
    >>>> -Nikolaus
    >>>>
    >>>> --
    >>>> GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
    >>>>
    >>>> »Time flies like an arrow, fruit flies like a Banana.«
    >>>
    >>>
    >>> --
    >>> GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
    >>>
    >>> »Time flies like an arrow, fruit flies like a Banana.«
    >>
    >>
    >> --
    >> GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
    >>
    >> »Time flies like an arrow, fruit flies like a Banana.«
    >
    >
    > --
    > GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
    >
    > »Time flies like an arrow, fruit flies like a Banana.«


    --
    GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

    »Time flies like an arrow, fruit flies like a Banana.«
    \
     
     \ /
      Last update: 2017-04-06 03:09    [W:3.459 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site