Messages in this thread | | | From | Moritz Fischer <> | Date | Wed, 5 Apr 2017 17:13:26 -0700 | Subject | Re: [PATCH] fpga fr br: fix warning for unexpected version number |
| |
Hi Matthew,
On Wed, Apr 5, 2017 at 3:25 PM, <matthew.gerlach@linux.intel.com> wrote:
>> Maybe you actually wanna bail out if you read a random other value >> instead of what you >> expect instead of printing a warning. > > > I thought about making it an error if the version didn't match, but it was a > dev_warn() before and that allowed folks to use the "old" driver with the > new IP version.
Or some random other piece of logic in the FPGA that happens to be mapped to that address ;-)
I agree we should've probably caught this in the initial review, but maybe we should change it.
Cheers,
Moritz
| |