lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH v2 3/5] clone: Disallown CLONE_THREAD with a shared sighand_struct
    On 04/05, Eric W. Biederman wrote:
    >
    > Oleg Nesterov <oleg@redhat.com> writes:
    >
    > I agree that changing userspace semantics is something to be very
    > careful with. But at least for purposes of discussion I think this is a
    > good patch.

    I agree that we need it with your approach,

    but imo it would be much better to not depend on the subtle changes
    like this. My 2/2 or your 1/5 are already bad enough.

    > I can avoid this change but it requires moving sighand->siglock
    > into signal_struct and introducing a new spinlock into sighand_struct
    > to just guard the signal handlers.

    Oh, this looks much, much worse to me.

    Oleg.

    \
     
     \ /
      Last update: 2017-04-05 20:12    [W:2.629 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site