lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 3/6] x86/apic: Extract APIC timer related code from apic_bsp_setup()
    On Wed, 29 Mar 2017, Dou Liyang wrote:
    > +/* Setup local APIC timer and get the Id*/
    > +static int __init apic_bsp_timer_setup(void)

    This does not make sense. The id and the timers have nothing to do with
    each other.

    > +{
    > + int id;
    > +
    > + if (x2apic_mode)
    > + id = apic_read(APIC_LDR);
    > + else
    > + id = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR));
    > +
    > + if (!skip_ioapic_setup && nr_ioapics && nr_legacy_irqs())
    > + check_timer();

    Why are you moving this to the APIC? check_timer() has absolutely nothing
    to do with the apic timer. It's a IOAPIC only issue and required to test
    that the IRQ0 interrupt delivery works through the IOAPIC.

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2017-04-05 13:58    [W:6.335 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site