Messages in this thread | | | Date | Wed, 5 Apr 2017 12:43:48 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup() |
| |
On Wed, 29 Mar 2017, Dou Liyang wrote:
> The init_bsp_APIC() setups the virtual wire mode through the local > APIC. > > The function name is unsuitable which might imply that the BSP's > APIC will be initialized here, actually, where it will be done is > almost at the end of start_kernel(). And the CONFIG X86_64 is also > imply the X86_LOCAL_APIC is y.
Correct, but X86_32 can have X86_LOCAL_APIC=n. And by removing the ifdefs you break that.
> /* > - * An initial setup of the virtual wire mode. > + * Setup the through-local-APIC virtual wire mode. > */ > -void __init init_bsp_APIC(void) > +void apic_virture_wire_mode_setup(void)
s/virture/virtual/ ?
Why is this function not longer marked __init ?
Thanks,
tglx
| |