Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 4 Apr 2017 20:00:14 +0300 | Subject | Re: [PATCH v5 2/3] gpio: wm831x: Add basic device tree support |
| |
On Thu, Mar 23, 2017 at 1:47 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Fri, 17 Mar 2017, Charles Keepax wrote: > >> Now the wm831x-core has basic DT support we can update this driver to >> allow use of the GPIOs within a device tree system. >> >> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> --- >> >> No changes since v4, still should go through Lee's tree. >> >> Thanks, >> Charles >> >> drivers/gpio/gpio-wm831x.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Applied, thanks.
>> +#ifdef CONFIG_OF_GPIO >> + wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node; >> +#endif
Just a bit of off topic.
If we can use struct fwnode_handle we might get rid of all those CONFIG_OF_GPIO in the drivers.
-- With Best Regards, Andy Shevchenko
| |