Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 4 Apr 2017 16:48:59 +0300 | Subject | Re: [PATCH v5 3/6] watchdog: iTCO_wdt: Add PMC specific noreboot update api |
| |
On Tue, Apr 4, 2017 at 3:24 AM, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > In some SoCs, setting noreboot bit needs modification to > PMC GC registers. But not all PMC drivers allow other drivers > to memory map their GC region. This could create mem request > conflict in watchdog driver. So this patch adds facility to allow > PMC drivers to pass noreboot update function to watchdog > drivers via platform data.
> /* Set the NO_REBOOT bit: this disables reboots */ > if (p->iTCO_version >= 2) { > - val32 = readl(p->gcs_pmc); > - val32 |= no_reboot_bit(p); > - writel(val32, p->gcs_pmc); > + if (p->update_noreboot_flag) > + p->update_noreboot_flag(true); > + else { > + val32 = readl(p->gcs_pmc); > + val32 |= no_reboot_bit(p); > + writel(val32, p->gcs_pmc); > + }
What I meant is to introduce helper(s) first and then fix this. Yes, I understand it might increase work for backporting (if even needed), but I still think it worth doing.
-- With Best Regards, Andy Shevchenko
| |