Messages in this thread | | | From | Kees Cook <> | Date | Mon, 3 Apr 2017 10:29:00 -0700 | Subject | Re: [PATCH] ACPICA: use designated initializers |
| |
On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert <robert.moore@intel.com> wrote: > Acpica is built with many compilers, even very old ones. It runs on at least 12 known operating systems, and very probably more. > > I'm sorry, but no, we are not going to start adding compiler-specific ifdefs/code in the base ACPICA code. > > I don't care what you do in the Linux-specific or gcc-specific headers, however. If this breaks a customer build, we (you) will hear about it rather quickly.
Since the change is specific to the one place ACPICA uses an all-function-pointer structure, I made the change local:
https://github.com/acpica/acpica/pull/248
would you rather this is in the .h files instead?
-Kees
-- Kees Cook Pixel Security
| |