Messages in this thread | | | Date | Mon, 3 Apr 2017 09:22:15 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver |
| |
On Tue, Mar 28, 2017 at 07:54:43PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > > Added device tree binding documentation for Aspeed I2C busses. > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2400-i2c-bus"; > > + bus = <0>; > > + clocks = <&clk_apb>; > > + clock-frequency = <100000>; > > For busses it's more traditional to make this "bus-frequency" but > that's a nit and Linux/fdt has not respected that tradition terribly > well. If you respin, it might be work changing.
Makes sense, but that's news to me. I'm still new to this DT stuff.
> The clock-frequency tends to be the frequency of the controller itself.
The clock binding has largely replaced that.
Rob
| |