lkml.org 
[lkml]   [2017]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] efi/efi_test: drop useless kfree
Date
Drop useless kfree when memdup_user() failed, since we have already
called kfree in memdup_user().

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/firmware/efi/test/efi_test.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
index 08129b7..00332ae 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg)
}

data = memdup_user(setvariable.data, setvariable.data_size);
- if (IS_ERR(data)) {
- kfree(name);
+ if (IS_ERR(data))
return PTR_ERR(data);
- }

status = efi.set_variable(name, &vendor_guid,
setvariable.attributes,
--
2.9.3
\
 
 \ /
  Last update: 2017-04-29 03:44    [W:0.727 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site