Messages in this thread | | | Date | Fri, 28 Apr 2017 13:29:13 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. |
| |
On Mon, Apr 24, 2017 at 01:12:09PM -0700, Eric Anholt wrote: > For the Raspberry Pi's bindings, the power domain also implicitly > turns on the clock and deasserts reset, but for the new Cygnus port we > start representing the clock in the devicetree. > > v2: Document the clock-names property, check for -ENOENT for no clock > in DT. > v3: Drop NULL checks around clk calls which embed NULL checks. > > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > .../devicetree/bindings/display/brcm,bcm-vc4.txt | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.h | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 31 +++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > index ca02d3e4db91..2318266f6481 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > @@ -59,6 +59,10 @@ Required properties for V3D: > - interrupts: The interrupt number > See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > > +Optional properties for V3D: > +- clocks: The clock the unit runs on > +- clock-names: Must be "v3d_clk"
clock-names is pointless for a single clock.
> + > Required properties for DSI: > - compatible: Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1" > - reg: Physical base address and length of the DSI block's registers
| |