| From | Linus Walleij <> | Date | Fri, 28 Apr 2017 10:49:32 +0200 | Subject | Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group |
| |
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> (...) > + pins_bidir { > + pinmux = <RZA1_PINMUX(3, 3, 2)>;/* P3_3 = ET_MDIO */ > + bi-directional; > + };
So I'm against merging this until someone explains what "bi-directional" actually means, electrically speaking. What happens physically on this pin?
I think this just means open drain.
It is dangerous to merge things we don't understand.
Surely someone inside Renesas can answer this question.
Yours, Linus Walleij
|