Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 25 Apr 2017 15:27:34 +0300 | Subject | Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission |
| |
On Mon, Apr 24, 2017 at 6:31 PM, Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote: > On Mon, 24 Apr 2017 12:14:14 +0300 > Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > >> On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure >> <jeremy.lefaure@lse.epita.fr> wrote: >> > The cpufv sysfs file is defined as readable by anyone even if the >> > attribute does not have a show function. The result of every read is an >> > IO error. This file should be write only. >> >> Per se patch looks good to me, though would be better to add show() >> hook as well? >> > It depends if we want to keep it write-only as it is documented in > Documentation/ABI/testing/sysfs-platform-asus-wmi. > > If we want to have this file read/write, I can send a v2 of this patch.
I dunno we need. So, since no answer from anyone I pushed this to testing, thanks!
-- With Best Regards, Andy Shevchenko
| |