Messages in this thread | | | Date | Mon, 24 Apr 2017 18:06:45 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name |
| |
On Mon, Apr 24, 2017 at 12:44:50PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa escreveu: > > Recent commit broke command name strip in perf_event__get_comm_ids > > function. It replaced left to right search for '\n' with rtrim, > > which actually does right to left search. It occasionally caught > > earlier '\n' and kept trash in the command name. > > > > Keeping the ltrim, but moving back the left to right '\n' search > > instead of the rtrim. > > perf/urgent? > > > Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name with {l,r}trim()") > > [acme@jouet linux]$ git tag --contains bdd97ca63faa > perf-core-for-mingo-4.12-20170411 > perf-core-for-mingo-4.12-20170413 > perf-core-for-mingo-4.12-20170419 > [acme@jouet linux]$ > > It is just in tip/perf/core, will put in acme/perf/core and push to Ingo > in my next pull req.
sure, I did not check.. just thought it's urgent from time POV ;-)
thanks, jirka
| |