Messages in this thread | | | Date | Mon, 24 Apr 2017 16:41:54 +0200 | From | Jan Kara <> | Subject | Re: [PATCH] fsnotify: remove a stray unlock |
| |
On Fri 21-04-17 13:52:20, Dan Carpenter wrote: > We recently shifted this code around, so we're no longer holding the > lock on this path. > > Fixes: 755b5bc681eb ("fsnotify: Remove indirection from mark list addition") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks! I've merged this patch.
Honza > > diff --git a/fs/notify/mark.c b/fs/notify/mark.c > index 55955ded338d..9991f8826734 100644 > --- a/fs/notify/mark.c > +++ b/fs/notify/mark.c > @@ -603,7 +603,6 @@ int fsnotify_add_mark_locked(struct fsnotify_mark *mark, struct inode *inode, > FSNOTIFY_MARK_FLAG_ATTACHED); > list_del_init(&mark->g_list); > atomic_dec(&group->num_marks); > - spin_unlock(&mark->lock); > > fsnotify_put_mark(mark); > return ret; -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |