lkml.org 
[lkml]   [2017]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fsnotify: remove a stray unlock
On Fri 21-04-17 13:52:20, Dan Carpenter wrote:
> We recently shifted this code around, so we're no longer holding the
> lock on this path.
>
> Fixes: 755b5bc681eb ("fsnotify: Remove indirection from mark list addition")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks! I've merged this patch.

Honza
>
> diff --git a/fs/notify/mark.c b/fs/notify/mark.c
> index 55955ded338d..9991f8826734 100644
> --- a/fs/notify/mark.c
> +++ b/fs/notify/mark.c
> @@ -603,7 +603,6 @@ int fsnotify_add_mark_locked(struct fsnotify_mark *mark, struct inode *inode,
> FSNOTIFY_MARK_FLAG_ATTACHED);
> list_del_init(&mark->g_list);
> atomic_dec(&group->num_marks);
> - spin_unlock(&mark->lock);
>
> fsnotify_put_mark(mark);
> return ret;
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2017-04-24 16:42    [W:0.034 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site