Messages in this thread | | | Date | Mon, 24 Apr 2017 09:11:29 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get |
| |
Mon, Apr 24, 2017 at 09:04:55AM CEST, bianpan2016@163.com wrote: >In function team_nl_send_options_get(), pointer skb keeps the return >value of function nlmsg_new(). When the call to genlmsg_put() fails, the >control flow directly returns and does not free skb. This will result in >a memory leak bug. This patch fixes it. > >Fixes: 8ea7fd0d8792 ("team: fix memory leak")
test1:~/net-next$ git log 8ea7fd0d8792 fatal: ambiguous argument '8ea7fd0d8792': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'
Please look up the commit that introduces the issue. Also no newline in between "fixes" and "signed off".
Also. The subject should be: [PATCH net 2/2] team: fix memory leak in team_nl_send_options_get
You can see this right away if you look in the mailing list archive...
> >Signed-off-by: Pan Bian <bianpan2016@163.com> >--- > drivers/net/team/team.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c >index dd3a2e9..85c0124 100644 >--- a/drivers/net/team/team.c >+++ b/drivers/net/team/team.c >@@ -2361,8 +2361,10 @@ static int team_nl_send_options_get(struct team *team, u32 portid, u32 seq, > > hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, > TEAM_CMD_OPTIONS_GET); >- if (!hdr) >+ if (!hdr) { >+ nlmsg_free(skb); > return -EMSGSIZE; >+ } > > if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) > goto nla_put_failure; >-- >1.9.1 > >
| |