lkml.org 
[lkml]   [2017]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()
On Sat, Apr 22 2017, Javier González wrote:

>> On 20 Apr 2017, at 07.38, NeilBrown <neilb@suse.com> wrote:
>>
>> blk_queue_split() is always called with the last arg being q->bio_split,
>> where 'q' is the first arg.
>>
>> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
>> q->bio_split.
>>
>> This is inconsistent and unnecessary. Remove the last arg and always use
>> q->bio_split inside blk_queue_split()
>>
>> Signed-off-by: NeilBrown <neilb@suse.com>
>> ---
>> block/blk-core.c | 2 +-
>> block/blk-merge.c | 9 ++++-----
>> block/blk-mq.c | 2 +-
>> drivers/block/drbd/drbd_req.c | 2 +-
>> drivers/block/pktcdvd.c | 2 +-
>> drivers/block/ps3vram.c | 2 +-
>> drivers/block/rsxx/dev.c | 2 +-
>> drivers/block/umem.c | 2 +-
>> drivers/block/zram/zram_drv.c | 2 +-
>> drivers/lightnvm/rrpc.c | 2 +-
>> drivers/md/md.c | 2 +-
>> drivers/s390/block/dcssblk.c | 2 +-
>> drivers/s390/block/xpram.c | 2 +-
>> include/linux/blkdev.h | 3 +--
>> 14 files changed, 17 insertions(+), 19 deletions(-)
>>
>
> It most probably made it to Jens' tree after you made these changes, but
> in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
> couple of places inside pblk_rw_io().

Ahh, yes - thanks. That will need to same small change.

Jens, do you prefer a resend, or and update patch, or to just add this
change manually?

Thanks,
NeilBrown
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-04-24 04:33    [W:0.088 / U:4.384 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site