lkml.org 
[lkml]   [2017]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/5] lightnvm: pblk: fix memory leak on error path
    From
    Date


    On 04/22/2017 01:32 AM, Javier González wrote:
    > When write recovery fails, Free memory for the recovery structure.
    >
    > Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"
    >
    > Signed-off-by: Javier González <javier@cnexlabs.com>
    > ---
    > drivers/lightnvm/pblk-write.c | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c
    > index 74f7413..a896190 100644
    > --- a/drivers/lightnvm/pblk-write.c
    > +++ b/drivers/lightnvm/pblk-write.c
    > @@ -142,6 +142,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd)
    > /* Logic error */
    > if (bit > c_ctx->nr_valid) {
    > WARN_ONCE(1, "pblk: corrupted write request\n");
    > + mempool_free(recovery, pblk->rec_pool);
    > goto out;
    > }
    >
    > @@ -149,6 +150,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd)
    > entry = pblk_rb_sync_scan_entry(&pblk->rwb, &ppa);
    > if (!entry) {
    > pr_err("pblk: could not scan entry on write failure\n");
    > + mempool_free(recovery, pblk->rec_pool);
    > goto out;
    > }
    >
    > @@ -162,6 +164,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd)
    > ret = pblk_recov_setup_rq(pblk, c_ctx, recovery, comp_bits, c_entries);
    > if (ret) {
    > pr_err("pblk: could not recover from write failure\n");
    > + mempool_free(recovery, pblk->rec_pool);
    > goto out;
    > }
    >
    >
    Reviewed-by: Matias Bjørling <matias@cnexlabs.com>

    \
     
     \ /
      Last update: 2017-04-22 10:59    [W:4.491 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site